[wp-trac] [WordPress Trac] #34945: HTTPS website with HTTP images

[WordPress Trac]

#34945: HTTPS website with HTTP images
--------------------------+--------------------------
 Reporter:  Angristan     |       Owner:  johnbillion
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  4.4.1
Component:  Media         |     Version:  4.4
 Severity:  normal        |  Resolution:
 Keywords:  https         |     Focuses:
--------------------------+--------------------------
Changes (by joemcgill):

 * status:  closed => reopened
 * resolution:  invalid =>
 * milestone:   => 4.4.1


Comment:

 @johnbillion I'd like to take another look at this for 4.4.1. While I
 agree with you that the issue shouldn't happen as long as either:

 * The site has the home and siteurl options set to URLs with https
 schemes, or
 * WP_HOME and WP_SITEURL constants defined with https schemes

 I've seen issues where people fail to set either when their site is HTTPS
 optional, and in those cases, all images will be broken as of 4.4 because
 any workarounds that have been put in place to fix the `src` attribute
 will not apply to the `srcset` attributes.
 [https://core.trac.wordpress.org/attachment/ticket/34945/34945.diff
 34945.diff] fixes this by making the `srcset` attributes scheme relative.
 Since we never write `srcset` attributes to the database, we don't have to
 worry about the kinds of concerns that make it difficult to make `src`
 attributes scheme relative.

 This should also fix the `srcset` issue affecting #34109 when only the
 admin is accessible over HTTPS.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34945#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform