[wp-trac] [WordPress Trac] #35249: Unit tests should pass

[WordPress Trac]

#35249: Unit tests should pass
------------------------------+------------------------------
 Reporter:  jrf               |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:
------------------------------+------------------------------

Comment (by jrf):

 @dossy Sorry, the previous message was meant for you.

 Anyway, I'd been running the tests in the background without keeping an
 eye on it, but now noticed some errors scrolling on the screen. So I had a
 quick look at the PHP error log and kind of think we have a winner:

 Don't know why the messages are showing up in french, but it basically
 translated to the key being too long, max key length 1000 and then the
 second one saying the table doesn't exist


 {{{
 [29-Dec-2015 18:16:18 UTC] WordPress database error La clé est trop
 longue. Longueur maximale: 1000 for query
                         CREATE TABLE wptests_dbdelta_test (
                                 id bigint(20) NOT NULL AUTO_INCREMENT,
                                 column_1 varchar(255) NOT NULL,
                                 PRIMARY KEY  (id),
                                 KEY key_1 (column_1),
                                 KEY compoud_key (id,column_1),
                                 FULLTEXT KEY fulltext_key (column_1)
                         ) ENGINE=MyISAM
                          made by PHPUnit_TextUI_Command::main,
 PHPUnit_TextUI_Command->run, PHPUnit_TextUI_TestRunner->doRun,
 PHPUnit_Framework_TestSuite->run, PHPUnit_Framework_TestSuite->run,
 PHPUnit_Framework_TestCase->run, PHPUnit_Framework_TestResult->run,
 PHPUnit_Framework_TestCase->runBare, Tests_dbDelta->setUp

 [29-Dec-2015 18:16:18 UTC] WordPress database error La table
 'wptestsuite.wptests_dbdelta_test' n'existe pas for query select column_1
 from wptests_dbdelta_test where column_1 = 'wcphilly2015' made by
 PHPUnit_TextUI_Command::main, PHPUnit_TextUI_Command->run,
 PHPUnit_TextUI_TestRunner->doRun, PHPUnit_Framework_TestSuite->run,
 PHPUnit_Framework_TestSuite->run, PHPUnit_Framework_TestCase->run,
 PHPUnit_Framework_TestResult->run, PHPUnit_Framework_TestCase->runBare,
 PHPUnit_Framework_TestCase->runTest, ReflectionMethod->invokeArgs,
 Tests_dbDelta->test_insert_into_table,
 Tests_dbDelta->assertTableRowHasValue

 }}}


 /cc @pento

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35249#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform