[wp-trac] [WordPress Trac] #35106: Responsive images break uploads with full path stored in metadata

[WordPress Trac]

#35106: Responsive images break uploads with full path stored in metadata
--------------------------------------+------------------------
 Reporter:  SergeyBiryukov            |       Owner:  joemcgill
     Type:  defect (bug)              |      Status:  accepted
 Priority:  normal                    |   Milestone:  4.4.1
Component:  Media                     |     Version:  4.4
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------

Comment (by dd32):

 [attachment:35106.diff] is based off [attachment:35106.2.patch]
  * Tested with /non-existant/path/wp-content/uploads/2015/12/image.jpg
  * Tested with /non-existant/path/wp-content/uploads/image.jpg
  * `_wp_get_attachment_relative_path()` returns a standard output, a
 foldername only, no `.` or filename.
  * Needed to suffix the image url to `_wp_get_attachment_relative_path()`
 in one spot
  * Needed to use `_wp_get_attachment_relative_path()` within the
 responsive image generation (It wasn't generating `srcset`s for them)

 @azaozz:
 > Ran into another similar case on old multisite installs.
 I can't quite work out the details here on what needs doing, or where
 you're proposing it needs to be taken into account, or where it's actually
 broken.. AFAICT multisite is already being handled right?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35106#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform