[wp-trac] [WordPress Trac] #35023: get_field_name() returns a bad field name if you pass it "display][avatar_size"

[WordPress Trac]

#35023: get_field_name() returns a bad field name if you pass it
"display][avatar_size"
-------------------------------------------------+-------------------------
 Reporter:  pbearne                              |       Owner:
     Type:  defect (bug)                         |  johnbillion
 Priority:  normal                               |      Status:  assigned
Component:  Widgets                              |   Milestone:  4.4.1
 Severity:  normal                               |     Version:  4.4
 Keywords:  has-patch has-unit-tests 2nd-        |  Resolution:
  opinion                                        |     Focuses:
                                                 |  administration
-------------------------------------------------+-------------------------

Comment (by dd32):

 I really can't see the difference between looking for a closing vs opening
 bracket. If one is provided without the other then it's going to result in
 an invalid field anyway. Given the following `strlen()` call uses `[` it's
 safer to use that same character for the tests.

 In other words - We don't really care if it breaks if you pass it invalid
 data.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35023#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform