[wp-trac] [WordPress Trac] #35227: Add unregister_taxonomy()

[WordPress Trac]

#35227: Add unregister_taxonomy()
--------------------------------------+------------------
 Reporter:  swissspidy                |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  4.5
Component:  Taxonomy                  |     Version:  2.3
 Severity:  normal                    |  Resolution:
 Keywords:  has-unit-tests has-patch  |     Focuses:
--------------------------------------+------------------
Changes (by swissspidy):

 * keywords:  has-unit-tests needs-patch => has-unit-tests has-patch


Comment:

 Replying to [comment:3 boonebgorges]:

 Thanks for your feedback so far! I incorporated it in the latest patch.

 I created new tickets for adding the individual helper methods:

 * #35234 for `WP::remove_query_var()`
 * #35235 for `remove_permastruct()`
 * #35236 for `remove_rewrite_tag()`

 [attachment:35227.2.diff] relies on these patches, making this one much
 more readable.

 > After unsetting array values in `remove_rewrite_tag()`, we could have
 gaps in the numerical array keys (ie: 0, 1, 3, 4). Does this matter? Worth
 resetting indexes using `array_values()` after `unset()`ing?

 I see no harm in not re-indexing the arrays.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35227#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform