[wp-trac] [WordPress Trac] #35089: Query var on non-public taxonomy remains boolean true since [35333]

[WordPress Trac]

#35089: Query var on non-public taxonomy remains boolean true since [35333]
--------------------------+---------------------------
 Reporter:  johnbillion   |       Owner:  boonebgorges
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.4.1
Component:  Taxonomy      |     Version:  4.4
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+---------------------------
Changes (by boonebgorges):

 * keywords:  has-patch 2nd-opinion => has-patch


Comment:

 Replying to [comment:3 boonebgorges]:
 > Replying to [comment:2 johnbillion]:
 > > Indeed it is. I only came across this bug because
 [https://wordpress.org/plugins/jigoshop/ Jigoshop] does this with its
 `shop_order_status` taxonomy.
 >
 > Do you know off the top of your head why Jigoshop sets `query_var =
 true`? Will [attachment:35089.diff] break something for them?

 I checked it out, and my guess is that Jigoshop does this only because of
 copy-and-pasting `register_taxonomy()` arguments. The plugin doesn't
 actually expect to see the query_var for non-public taxonomies anywhere.

 I think that [attachment:35089.diff] is the right move here: prior to 4.4,
 it was impossible for a query_var to be set to a boolean, and it's boolean
 values that are causing the `wp_list_filter()` issues.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35089#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform