[wp-trac] [WordPress Trac] #35215: Setting help tab priorities fails to correctly order the tabs

[WordPress Trac]

#35215: Setting help tab priorities fails to correctly order the tabs
-------------------------------------------------+-------------------------
 Reporter:  meitar                               |       Owner:  jorbin
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  4.4.1
Component:  Help/About                           |     Version:  trunk
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests commit      |     Focuses:
  fixed-major                                    |  administration
-------------------------------------------------+-------------------------
Changes (by dd32):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"36104"]:
 {{{
 #!CommitTicketReference repository="" revision="36104"
 Help Tab Order should be based on the Priority Argument

 [34370] made the order that tabs are returned respect the order they are
 added, however it broke the respect of priority. By using a ksort instead
 of a sort, we can restore that default behavior. This adjusts the unit
 tests so that both order added and priority are tested.

 Merges [36089] to the 4.4 branch.
 Props meitar, swissspidy, jorbin
 Fixes #35215. See #33941.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35215#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform