[wp-trac] [WordPress Trac] #35057: bug in new default_hidden_columns filter

WordPress Trac noreply at wordpress.org
Sat Dec 26 04:04:38 UTC 2015


#35057: bug in new default_hidden_columns filter
-------------------------------------+-----------------------------
 Reporter:  dwenaus                  |       Owner:  helen
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.4.1
Component:  Administration           |     Version:  4.4
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  administration
-------------------------------------+-----------------------------

Comment (by jorbin):

 I like the idea of using the same method we are using elsewhere.

 A few small notes on your patch @Compute:
 - Let's not change formatting of the lines not directly being changed.
 This can mess up debugging with `svn blame`, so even if they don't match
 the current code standards, we shouldn't change them.
 - Adding the additional param to the hidden_columns filter means we also
 need to add an `@since` with the changelog. See
 https://make.wordpress.org/core/handbook/best-practices/inline-
 documentation-standards/php/#since-section-changelogs

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35057#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list