[wp-trac] [WordPress Trac] #35215: Setting help tab priorities fails to correctly order the tabs

[WordPress Trac]

#35215: Setting help tab priorities fails to correctly order the tabs
---------------------------------------------+-----------------------------
 Reporter:  meitar                           |       Owner:
     Type:  defect (bug)                     |      Status:  new
 Priority:  normal                           |   Milestone:  4.4.1
Component:  Help/About                       |     Version:  trunk
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch has-unit-tests commit  |     Focuses:  administration
---------------------------------------------+-----------------------------
Changes (by swissspidy):

 * keywords:  has-patch => has-patch has-unit-tests commit
 * milestone:  Awaiting Review => 4.4.1


Comment:

 Yeah it looks like the priority sorting didn't work properly after
 [34370].

 I just uploaded [attachment:35215.diff] with updated unit tests that test
 the behaviour of adding three tabs with priorities of `2`, `10` and `40`.
 Without the change to `ksort`, the tabs are returned in incorrect order.

 I also used `assertSame` in the unit test to make sure the types match all
 the time.

 Moving this to the 4.4.1 milestone since it's a regression.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35215#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform