[wp-trac] [WordPress Trac] #35176: Update button should be disabled if there haven't been any changes.

WordPress Trac noreply at wordpress.org
Tue Dec 22 02:01:41 UTC 2015


#35176: Update button should be disabled if there haven't been any changes.
---------------------------+---------------------------------
 Reporter:  EmpireOfLight  |       Owner:
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Editor         |     Version:  4.4
 Severity:  normal         |  Resolution:
 Keywords:  close          |     Focuses:  ui, administration
---------------------------+---------------------------------

Comment (by EmpireOfLight):

 Replying to [comment:9 azaozz]:
 > Thinking this may be a "not-so-great" UI change. Two reasons:
 > - The whole Edit Post screen still has the feel of a form, and the
 submit/save buttons on most forms are not disabled when the forms are
 "empty".
 Yeah, disabling it would be bad. But what about just changing the
 appearance when something's changed on the page? @khag7 's JS does a nice
 job of this; I tried it and it felt right on.

 It does feel like a form, and that's a bad thing. It should feel like an
 app, and apps do intuitive stuff like help you remember if you changed
 something on the interface.

 > - We can (probably) detect changes in all metaboxes (they are saved
 together with the post, see [#comment:2 comment 2]), but may miss changes
 to elements added by plugins, especially when done with JS. For example:
 > {{{
 > jQuery( '#post' ).submit( function() {
 >   if ( [some condition] ) {
 >     jQuery( '.my-field', this ).val( 'My Value' );
 >   }
 > });
 > }}}
 No sure I understand the issue here...so if a plugin does something when
 the update button is pressed, it won't happen because of the new
 functionality?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35176#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list