[wp-trac] [WordPress Trac] #35182: Site icon URLs don't respect SSL in admin

[WordPress Trac]

#35182: Site icon URLs don't respect SSL in admin
----------------------------+-----------------------------
 Reporter:  kasparsd        |      Owner:
     Type:  defect (bug)    |     Status:  new
 Priority:  normal          |  Milestone:  Awaiting Review
Component:  Administration  |    Version:  4.4
 Severity:  normal          |   Keywords:
  Focuses:                  |
----------------------------+-----------------------------
 It appears that the following check in `wp_get_attachment_url()`:

 {{{#!php
 if ( is_ssl() && ! is_admin() && 'wp-login.php' !== $GLOBALS['pagenow'] )
 {
         $url = set_url_scheme( $url );
 }
 }}}

 prevents `get_site_icon_url()` from using SSL for serving the icon links
 in the head, which results in non-HTTPS icon URLs on all admin pages:

 [[Image(http://kaspars.net/wp-content/uploads/2015/12/site-icon-url-
 https.png)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35182>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform