[wp-trac] [WordPress Trac] #8071: Refrain from querying all the comments on a post when paged

[WordPress Trac]

#8071: Refrain from querying all the comments on a post when paged
------------------------------------+---------------------------
 Reporter:  markjaquith             |       Owner:  boonebgorges
     Type:  task (blessed)          |      Status:  closed
 Priority:  normal                  |   Milestone:  4.4
Component:  Comments                |     Version:  2.7
 Severity:  normal                  |  Resolution:  fixed
 Keywords:  dev-feedback has-patch  |     Focuses:
------------------------------------+---------------------------

Comment (by boonebgorges):

 In [changeset:"36041"]:
 {{{
 #!CommitTicketReference repository="" revision="36041"
 Respect approval status when determining comment page count in
 `comments_template()`.

 Since 4.4, when fetching the first page of comments and the 'newest'
 comments
 are set to display first, `comments_template()` must perform arithmetic to
 determine which comments to show. See #8071. This arithmetic requires the
 total comment count for the current post, which is calculated with a
 separate
 `WP_Comment_Query`. This secondary comment query did not properly account
 for
 non-approved comment statuses; all unapproved comments should be part of
 the
 comment count for admins, and individual users should have their own
 unapproved comments included in the count. As a result,
 `comments_template()`
 was, in some cases, being fooled into thinking that a post had fewer
 comments
 available for pagination than it actually had, which resulted in empty
 pages
 of comments.

 We correct this problem by mirroring 'status' and 'include_unapproved'
 params
 of the main comment query within the secondary query used to calculate
 pagination.

 Merges [36040] to the 4.4 branch.

 Fixes #35068.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/8071#comment:67>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform