[wp-trac] [WordPress Trac] #35068: Comments not showing up when there are unapproved messages

[WordPress Trac]

#35068: Comments not showing up when there are unapproved messages
-------------------------------------+---------------------------
 Reporter:  arash_hemmat             |       Owner:  boonebgorges
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  4.4.1
Component:  Comments                 |     Version:  4.4
 Severity:  critical                 |  Resolution:  fixed
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+---------------------------
Changes (by boonebgorges):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"36040"]:
 {{{
 #!CommitTicketReference repository="" revision="36040"
 Respect approval status when determining comment page count in
 `comments_template()`.

 Since 4.4, when fetching the first page of comments and the 'newest'
 comments
 are set to display first, `comments_template()` must perform arithmetic to
 determine which comments to show. See #8071. This arithmetic requires the
 total comment count for the current post, which is calculated with a
 separate
 `WP_Comment_Query`. This secondary comment query did not properly account
 for
 non-approved comment statuses; all unapproved comments should be part of
 the
 comment count for admins, and individual users should have their own
 unapproved comments included in the count. As a result,
 `comments_template()`
 was, in some cases, being fooled into thinking that a post had fewer
 comments
 available for pagination than it actually had, which resulted in empty
 pages
 of comments.

 We correct this problem by mirroring 'status' and 'include_unapproved'
 params
 of the main comment query within the secondary query used to calculate
 pagination.

 Fixes #35068.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35068#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform