[wp-trac] [WordPress Trac] #35082: get_adjacent_post() when using in term doesn't account for child terms

[WordPress Trac]

#35082: get_adjacent_post() when using in term doesn't account for child terms
--------------------------------------+-----------------------------
 Reporter:  WazzaJB                   |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Future Release
Component:  Posts, Post Types         |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  template
--------------------------------------+-----------------------------
Changes (by WazzaJB):

 * keywords:  needs-refresh needs-unit-tests => has-patch has-unit-tests


Comment:

 Hey @boonebgorges, great to be here!

 Thanks for the pointers, and also thanks for your advice over Slack. I've
 updated the changes against trunk and also added a unit test which helps
 illustrate my point.

 Although I know this change will not effect any of my current sites, I do
 believe this could potentially create problems on sites where they are
 happy with the way it currently fetches adjacent posts within terms.

 I feel we should be concerned about backwards compatibility for a change
 like this, however don't know the standard protocol in terms of whether we
 add an additional argument to the function or whether we provide a way for
 developers to 'turn off' this new functionality by way of a filter?

 Happy to modify my patch either way.

 Thanks again!

 PS: Really sorry if i've got the workflow keywords wrong, getting to grips
 with things :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35082#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform