[wp-trac] [WordPress Trac] #35160: Reorganize Feeds Unit Tests & Add Test Coverage for Atom

[WordPress Trac]

#35160: Reorganize Feeds Unit Tests & Add Test Coverage for Atom
--------------------------------------+------------------------------
 Reporter:  stevenkword               |       Owner:
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Feeds                     |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-unit-tests has-patch  |     Focuses:
--------------------------------------+------------------------------
Description changed by stevenkword:

Old description:

> In Make WordPress Core, we refer to the syndication components as the
> "Feeds Component".  However, in our unit tests, we have the group
> labelled in its singular form, "Feed".  I proposing that we rename this
> group to its plural form and relocate these test into the
> `tests/phpunit/tests/feeds/` directory.
>
> IMPORTANT -- I don't believe svn diff has the ability to delete
> directories, so if this proposal is accepted, we need to make sure to
> manually rename/delete the 'tests/phpunit/tests/feed' directory before
> commit.  Apologies in advance!
>
> In addition to renaming the group, this ticket aims to separate generic
> syndication tests from the RSS-specific test and additionally provides
> test coverage for Atom feeds, which currently do not exists.
>
> I feel it is also important to note that this will mandate a refresh of
> any feeds-related unit tests that are currently sitting in trac.  I am
> willing to commit to refreshing those personally, but would prefer to
> hold on pending approval from the Committers.
>
> Lastly, this patch proposes a new file,
> `tests/phpunit/tests/feeds/common.php`, which contains 3 brand new tests
> that will currently fail against trunk.  I wanted to leave these in here
> to demonstrate what I was thinking with the `common` tests.  These relate
> to ticket #30210.  However, if I take them back out, the purpose of the
> `common.php` file becomes much less apparant.  Let's discuss!

New description:

 In Make WordPress Core, we refer to the syndication components as the
 "Feeds Component".  However, in our unit tests, we have the group labelled
 in its singular form, "Feed".  I proposing that we rename this group to
 its plural form and relocate these test into the
 `tests/phpunit/tests/feeds/` directory.

 IMPORTANT -- I don't believe svn diff has the ability to delete
 directories, so if this proposal is accepted, we need to make sure to
 manually rename/delete the `tests/phpunit/tests/feed` directory before
 commit.  Apologies in advance!

 In addition to renaming the group, this ticket aims to separate generic
 syndication tests from the RSS-specific test and additionally provides
 test coverage for Atom feeds, which currently do not exists.

 I feel it is also important to note that this will mandate a refresh of
 any feeds-related unit tests that are currently sitting in trac.  I am
 willing to commit to refreshing those personally, but would prefer to hold
 on pending approval from the Committers.

 Lastly, this patch proposes a new file,
 `tests/phpunit/tests/feeds/common.php`, which contains 3 brand new tests
 that will currently fail against trunk.  I wanted to leave these in here
 to demonstrate what I was thinking with the `common` tests.  These relate
 to ticket #30210.  However, if I take them back out, the purpose of the
 `common.php` file becomes much less apparant.  Let's discuss!

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35160#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform