[wp-trac] [WordPress Trac] #26396: Implement a generic clearfix
WordPress Trac
noreply at wordpress.org
Fri Dec 18 13:34:41 UTC 2015
#26396: Implement a generic clearfix
----------------------------+-----------------------
Reporter: helen | Owner: afercia
Type: enhancement | Status: assigned
Priority: low | Milestone: 4.5
Component: Administration | Version: 4.4
Severity: minor | Resolution:
Keywords: needs-patch | Focuses: ui
----------------------------+-----------------------
Changes (by afercia):
* owner: => afercia
* status: new => assigned
* focuses: ui, administration => ui
* version: => 4.4
* milestone: Future Release => 4.5
Comment:
The original clearfix mentioned in the ticket description
[https://core.trac.wordpress.org/browser/trunk/src/wp-admin/css/nav-
menus.css?rev=35473#L763 is now in nav-menus.css]. On the other hand,
[35673] introduced a new rule in common.css, currently used only for the
"navigation tabs" container:
{{{
/* contain floats */
.nav-tab-wrapper:after {
content: "";
display: table;
clear: both;
}
}}}
I'd suggest to just add a generic class name, maybe "wp-clearfix"?
{{{
/* modern clearfix */
.wp-clearfix:after,
.nav-tab-wrapper:after {
content: "";
display: table;
clear: both;
}
}}}
cc @michaelarestad cause I know he's passionate about CSS naming
conventions :)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/26396#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list