[wp-trac] [WordPress Trac] #10676: current-cat-ancestor in wp_list_categories

WordPress Trac noreply at wordpress.org
Thu Dec 17 15:50:22 UTC 2015


#10676: current-cat-ancestor in wp_list_categories
----------------------------------------+-----------------------------
 Reporter:  spathon                     |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  Future Release
Component:  Taxonomy                    |     Version:  2.8.5
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:
----------------------------------------+-----------------------------
Changes (by boonebgorges):

 * keywords:  has-patch 2nd-opinion needs-unit-tests => has-patch needs-
     unit-tests


Comment:

 The technique in [attachment:10676_wordpress_4_4.diff] looks good to me.
 Improved cache support for `get_term()` in 4.4 should minimize the
 overhead of walking the ancestor tree like this.

 Can we get tests for this? At least one, which would show the class being
 applied to multiple levels of ancestor. (We test these classes via
 `wp_list_categories()`:
 https://core.trac.wordpress.org/browser/tags/4.4/tests/phpunit/tests/category/wpListCategories.php

--
Ticket URL: <https://core.trac.wordpress.org/ticket/10676#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list