[wp-trac] [WordPress Trac] #35084: check for post status in get_page_uri causes issues with permalinks
WordPress Trac
noreply at wordpress.org
Thu Dec 17 07:37:24 UTC 2015
#35084: check for post status in get_page_uri causes issues with permalinks
---------------------------------------------+-----------------------
Reporter: tharsheblows | Owner: netweb
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.4.1
Component: Permalinks | Version: 4.4
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests commit | Focuses:
---------------------------------------------+-----------------------
Comment (by DrewAPicture):
Replying to [comment:13 netweb]:
> Patch [attachment:35084.3.diff] includes PHPDoc `@since` references for
devhub changelog
>
> Replying to [comment:12 DrewAPicture]:
> > If it was important enough to change/fix in a point release, it
qualifies for a changelog entry. The normal meter for a changelog entry is
"significant changes" to functionality or logic. For more on the basis of
changelogs, see the [https://make.wordpress.org/core/handbook/best-
practices/inline-documentation-standards/php/#since-section-changelogs
inline docs standard].
> Thanks Drew :) (Maybe a footnote in those docs explaining that would
help the next person with same question)
Not sure I understand what's missing. There's an entire paragraph on what
qualifies as a "significant change" :-)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35084#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list