[wp-trac] [WordPress Trac] #35058: PHP Fatal when map_deep tries to work on an object that has a property by reference

[WordPress Trac]

#35058: PHP Fatal when map_deep tries to work on an object that has a property by
reference
--------------------------+--------------------
 Reporter:  jeff@…        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.4.1
Component:  Formatting    |     Version:  4.4
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+--------------------

Comment (by swissspidy):

 @jeff at pyebrook.com Thanks, that was quick!

 Just two failing tests locally:


 {{{
 There were 2 failures:

 1)
 Tests_Formatting_MapDeep::test_map_deep_should_map_each_property_of_an_object
 Failed asserting that two objects are equal.
 --- Expected
 +++ Actual
 @@ @@
  stdClass Object (
 -    'var0' => 'ababa'
 +    'var0' => 'ababababa'
      'var1' => 'xbaba'
  )

 2)
 Tests_Formatting_MapDeep::test_map_deep_should_map_each_array_property_of_an_object
 Failed asserting that two objects are equal.
 --- Expected
 +++ Actual
 @@ @@
  stdClass Object (
 -    'var0' => 'ababa'
 +    'var0' => 'ababababa'
      'var1' => Array (...)
  )

 }}}

 At first glance I have no idea why the first var gets processed twice.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35058#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform