[wp-trac] [WordPress Trac] #35103: login_url Filter is now applied to Login Form Action Attribute

[WordPress Trac]

#35103: login_url Filter is now applied to Login Form Action Attribute
------------------------------------+--------------------
 Reporter:  salcode                 |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  4.4.1
Component:  Login and Registration  |     Version:  4.4
 Severity:  normal                  |  Resolution:
 Keywords:  needs-patch             |     Focuses:
------------------------------------+--------------------

Comment (by salcode):

 Thanks for your patch @KrissieV but this only addresses login forms
 generated with the function `wp_login_form()`.

 This issue also arises with the `action` attribute on the form tag on the
 login page.  (e.g. http://example.com/wp-login.php).

 If you refer to
 https://core.trac.wordpress.org/attachment/ticket/34925/34925.patch you
 can see the second change made in `wp-login.php` that addresses this.

 This other patch also addressed rolling back the use of

 {{{
 wp_registration_url()
 }}}
 which has changed since that time to
 {{{
 set_url_scheme( wp_registration_url(), 'login_post' )
 }}}

 In the patch, it was suggested rolling this back to
 {{{
 site_url( 'wp-login.php?action=register', 'login_post' )
 }}}

 I support this change too since `wp_registration_url()` calls

 {{{
 site_url( 'wp-login.php?action=register', 'login' )
 }}}

 which applies the scheme `login` instead of the appropriate `login_post`
 scheme in this context.

 While I am not aware of any bugs due to the `wp_registration_url()` call,
 I think we should roll it back anyway since the wrong scheme is being
 applied.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35103#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform