[wp-trac] [WordPress Trac] #20578: Allow users to delete a plugin without uninstalling

[WordPress Trac]

#20578: Allow users to delete a plugin without uninstalling
-------------------------------------------------+-------------------------
 Reporter:  scribu                               |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Future
Component:  Plugins                              |  Release
 Severity:  normal                               |     Version:
 Keywords:  ux-feedback ui-feedback has-patch    |  Resolution:
  has-screenshots                                |     Focuses:  ui
-------------------------------------------------+-------------------------
Changes (by swissspidy):

 * keywords:  ux-feedback ui-feedback needs-patch => ux-feedback ui-feedback
     has-patch has-screenshots
 * milestone:  Awaiting Review => Future Release


Comment:

 [attachment:20578.diff] is a new patch incorporating some feedback.

 After (hopefully) removing the list of files which will be deleted (see
 #34439), I thought I should give it a shot. Why not even consider this for
 4.5?

 Some highlights:

 '''Makes the 'Return to Plugins page' button a link'''

 * Moves the link below the buttons. Works great because of #34439.
 * I slightly changed the wording because that string is already used
 elsewhere

 '''Adds primary and secondary buttons'''

 Two buttons for an uninstallable plugin, only a single button for one
 without an uninstall handler.

 Note: Since you can choose if data should be deleted or not, the `(will
 also delete its data)` text can be removed.

 '''Docs''

 Adds the `$uninstall_plugin` flag to the `delete_plugin` and
 `deleted_plugin` hooks. Updates DocBlocks properly.

 '''Screenshots'''

 1. Delete single plugin (no uninstall handler)

 [[Image(https://cldup.com/M0zjGHSeQd.png, 400px)]]

 2. Delete single plugin (uninstall handler)

 [[Image(https://cldup.com/RPgo2aXM2x.png, 400px)]]

 3. Delete multiple plugins (no uninstall handler)

 [[Image(https://cldup.com/-lZM8J3ggz.png, 400px)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/20578#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform