[wp-trac] [WordPress Trac] #34988: Screen Options on taxonomy edit screen

[WordPress Trac]

#34988: Screen Options on taxonomy edit screen
-------------------------------------------------+-------------------------
 Reporter:  milindmore22                         |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  4.5
Component:  Taxonomy                             |     Version:  4.4
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch dev-feedback needs-        |     Focuses:
  testing                                        |  administration
-------------------------------------------------+-------------------------

Comment (by swissspidy):

 From my previous comment:

 > I'll update the patch to move the `$term = get_term( $term_id,
 $taxonomy, OBJECT, 'edit' );` check up. There's no need for a separate
 taxonomy check.

 The whole `term.php` can be simplified even further:

 * Passing a taxonomy is not really necessary because there are no shared
 terms anymore.
 * Passing the post type can be optional, because we can always default to
 the first `object_type` associated with the taxonomy if no post type was
 passed.

 Because of that, [35875] is kinda made obsolete here, because we need to
 check for the term before loading the admin header. Pinging @afercia for
 feedback :)

 Note that in the previous patches, the `<title>` was broken. My new patch
 [attachment:34988.5.patch]  fixes this by correctly setting `$title`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34988#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform