[wp-trac] [WordPress Trac] #35045: Responsive images not added when effective scheme differs from image src scheme

[WordPress Trac]

#35045: Responsive images not added when effective scheme differs from image src
scheme
-------------------------------------------------+-------------------------
 Reporter:  webaware                             |       Owner:
     Type:  defect (bug)                         |  johnbillion
 Priority:  normal                               |      Status:  reviewing
Component:  Media                                |   Milestone:  4.4.1
 Severity:  normal                               |     Version:  4.4
 Keywords:  has-patch needs-testing has-unit-    |  Resolution:
  tests                                          |     Focuses:  template
-------------------------------------------------+-------------------------

Comment (by azaozz):

 In 35045.5.diff:
 - Move the `false !== strpos( $image_src, $dirname . $image['file'] )` at
 the beginning of the loop. Otherwise it won't match when the image src is
 for a size wider than `$max_srcset_image_width`.
 - Simplify/cleanup a bit.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35045#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform