[wp-trac] [WordPress Trac] #35032: Shiny plugin updates fails if slug has special characters

WordPress Trac noreply at wordpress.org
Wed Dec 16 06:26:52 UTC 2015

#35032: Shiny plugin updates fails if slug has special characters
 Reporter:  khag7                    |       Owner:  adamsilverstein
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Upgrade/Install          |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:

Comment (by khag7):

 I'm most of the way through reworking the updates.js to not rely on slugs
 at all. At that point, we can actually ignore the patch I already
 submitted and I will submit a new one.

 One thing I'm waiting on... there is a patch on ticket #18974 which will
 add the data-plugin attribute to solve a different issue. We can make use
 of that same attribute in updates.js to have better jQuery selectors. Do I
 wait for the patch on #18974 to be committed or do I use that patch as
 part of this patch? I think it would cause a conflict later when someone
 tries to commit and the changes were already made.

Ticket URL: <https://core.trac.wordpress.org/ticket/35032#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list