[wp-trac] [WordPress Trac] #35045: Responsive images not added when effective scheme differs from image src scheme

[WordPress Trac]

#35045: Responsive images not added when effective scheme differs from image src
scheme
-------------------------------------------------+-------------------------
 Reporter:  webaware                             |       Owner:
     Type:  defect (bug)                         |  johnbillion
 Priority:  normal                               |      Status:  reviewing
Component:  Media                                |   Milestone:  4.4.1
 Severity:  normal                               |     Version:  4.4
 Keywords:  has-patch needs-testing has-unit-    |  Resolution:
  tests                                          |     Focuses:  template
-------------------------------------------------+-------------------------

Comment (by azaozz):

 Was also thinking we can move the "URL exists in image meta" check to
 wp_calculate_image_srcset() as @joemcgill mentions
 [https://core.trac.wordpress.org/ticket/35102#comment:8 here]. It will
 introduce very little overhead when we are certain the attachment ID
 matches the image (for galleries, etc.).

 As far as I see we need to check if the image src matches one of the
 srcset URLs after the `'wp_calculate_image_srcset'` filter at the end of
 wp_calculate_image_srcset(). Are there any legitimate use cases where this
 won't happen?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35045#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform