[wp-trac] [WordPress Trac] #35075: Comment cache ignores custom query vars

[WordPress Trac]

#35075: Comment cache ignores custom query vars
-----------------------------+--------------------------
 Reporter:  jason_the_adams  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  4.5
Component:  Comments         |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:                   |     Focuses:  performance
-----------------------------+--------------------------
Changes (by boonebgorges):

 * keywords:  needs-docs =>


Comment:

 A filter for this purpose doesn't seem like the most straightforward way
 to address the issue. It seems to me that we ought to be using all query
 vars in all cases - better for the cache to be too fine-grained than too
 coarse-grained. That said, the current technique for constructing a cache
 key is used in a number of places through WP (`get_terms()` for example).
 Before we make any changes, it'd be nice for someone to find the
 changeset(s) where the technique was introduced, to get a better
 understanding of the potential ramifications of using all query vars to
 build the key.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35075#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform