[wp-trac] [WordPress Trac] #35084: check for post status in get_page_uri causes issues with permalinks

[WordPress Trac]

#35084: check for post status in get_page_uri causes issues with permalinks
--------------------------------------+--------------------
 Reporter:  tharsheblows              |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  4.4.1
Component:  Permalinks                |     Version:  4.4
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+--------------------

Comment (by netweb):

 Attachment [attachment:35084.2.diff] looks good from my perspective for
 both the patch and tests.

 Some `@since` docs should be added for recent changes for the developer
 changelog reference, adding `@since 4.4.0` docs for [34001], and then do
 we add `@since 4.4.1` for the proposed change here?

 ----


 I've added some test to bbPress in [bbpress:changeset:5962] that adds some
 assertions for bbPress' forum custom post type `private` and `hidden`
 posts statuses with hierarchal nested forum URL's e.g:
 * http://src.wordpress-develop.dev/forums/forum/hidden-category/hidden-
 forum/
 * http://src.wordpress-develop.dev/forums/forum/private-category/private-
 forum/

 These assertions are failing for /trunk and 4.4 branches, with
 [attachment:35084.2.diff] applied these assertions pass.

 See https://travis-ci.org/ntwb/bbPress/builds/96968246

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35084#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform