[wp-trac] [WordPress Trac] #30787: Shrinkwrap NPM dependencies

[WordPress Trac]

#30787: Shrinkwrap NPM dependencies
------------------------------+--------------------
 Reporter:  jorbin            |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  4.4.1
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  2nd-opinion       |     Focuses:
------------------------------+--------------------

Comment (by nacin):

 We have two opportunities to shrinkwrap a branch. One, as the branch is
 created with a copy. (No.) Two, after the fact — but might that means the
 build will have run, which will result in a mess.

 I've again copied over the node_modules from trunk to branches/4.4 on the
 build server. The next commit should clean things up. I can also update
 the build script to copy over node_modules whenever a branch is created.

 I'd like us to shrinkwrap branches for sure. Can we enforce that through a
 unit test somehow?

 I don't love the idea of maintaining a shrinkwrapped file in trunk, as
 it'd probably get pretty tedious. On the other hand, I don't love that our
 builds are only reproducible on a single build server.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30787#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform