[wp-trac] [WordPress Trac] #35025: Performance regression in comments_template in 4.4

[WordPress Trac]

#35025: Performance regression in comments_template in 4.4
------------------------------------+---------------------------
 Reporter:  rogerhub                |       Owner:  boonebgorges
     Type:  defect (bug)            |      Status:  closed
 Priority:  normal                  |   Milestone:  4.4.1
Component:  Comments                |     Version:  4.4
 Severity:  normal                  |  Resolution:  fixed
 Keywords:  has-patch dev-feedback  |     Focuses:  performance
------------------------------------+---------------------------
Changes (by boonebgorges):

 * owner:   => boonebgorges
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"35931"]:
 {{{
 #!CommitTicketReference repository="" revision="35931"
 Don't use `array_merge()` when building comment children arrays.

 `array_merge()` is much slower than building the combined array using a
 `foreach` loop. The performance difference was causing a speed regression
 with
 the `get_children()` functionality introduced in 4.4.

 Props rogerhub.
 Fixes #35025.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35025#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform