[wp-trac] [WordPress Trac] #33887: Multisite update from SSL network fails on non SSL domains

[WordPress Trac]

#33887: Multisite update from SSL network fails on non SSL domains
-------------------------------------+-------------------------------------
 Reporter:  typify                   |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Upgrade/Install          |     Version:  4.3
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  administration,
  https dev-feedback                 |  multisite
-------------------------------------+-------------------------------------
Changes (by flixos90):

 * keywords:  has-patch, needs-testing, https => has-patch needs-testing
     https dev-feedback


Comment:

 I just stumbled across the same issue.

 I came up with a different solution in [attachment:33887-alternative.diff]
 which solves the problem by only changing the `set_url_scheme()` function.
 This way we don't need to change the parameter everywhere where we want
 the original version of the URL.

 My approach is to rely on whether we're currently switched in a multisite
 installation and then rely on the scheme of the original URL if possible
 (since we cannot rely on `is_ssl()` here). I still took
 `force_ssl_admin()` into account since I feel this is a global setting,
 but correct me if I'm wrong.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33887#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform