[wp-trac] [WordPress Trac] #35051: Remove title attributes: the Network Themes list table
WordPress Trac
noreply at wordpress.org
Mon Dec 14 08:43:59 UTC 2015
#35051: Remove title attributes: the Network Themes list table
-------------------------------------+-------------------------------------
Reporter: afercia | Owner: afercia
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.5
Component: Networks and Sites | Version: 4.4
Severity: normal | Resolution:
Keywords: has-screenshots has- | Focuses: ui, accessibility,
patch commit | multisite
-------------------------------------+-------------------------------------
Comment (by SergeyBiryukov):
One issue with ternary operators is that translator comment with only be
parsed for the first string, but not for the second:
{{{
/* translators: %s: theme name */
sprintf( ( $this->is_site_themes ? __( 'Enable %s' ) : __( 'Network Enable
%s' ) ), $theme->display( 'Name' ) )
}}}
[attachment:35051.3.patch] replaces string concatenation with
`add_query_arg()` and `sprintf()`, which fixes the issue and makes these
lines more readable.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35051#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list