[wp-trac] [WordPress Trac] #35045: Responsive images not added when effective scheme differs from image src scheme

[WordPress Trac]

#35045: Responsive images not added when effective scheme differs from image src
scheme
-------------------------------------------------+-------------------------
 Reporter:  webaware                             |       Owner:
     Type:  defect (bug)                         |  johnbillion
 Priority:  normal                               |      Status:  reviewing
Component:  Media                                |   Milestone:  4.4.1
 Severity:  normal                               |     Version:  4.4
 Keywords:  has-patch needs-testing has-unit-    |  Resolution:
  tests                                          |     Focuses:  template
-------------------------------------------------+-------------------------

Comment (by joemcgill):

 This bug was introduced in r35820 because we build a full URL for each
 size and then compare them against the `src` of the image. Instead, we
 could just compare filenames, which would avoid trying to match schemes in
 the first place.

 [https://core.trac.wordpress.org/attachment/ticket/35045/35045.diff
 35045.diff] changes the logic introduced in r35820 to compare file names
 instead of full URLs.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35045#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform