[wp-trac] [WordPress Trac] #34561: Abstract some embed template code into functions

WordPress Trac noreply at wordpress.org
Sun Dec 13 20:39:25 UTC 2015


#34561: Abstract some embed template code into functions
-------------------------+-----------------------------
 Reporter:  johnbillion  |       Owner:  DrewAPicture
     Type:  enhancement  |      Status:  reviewing
 Priority:  normal       |   Milestone:  Future Release
Component:  Embeds       |     Version:  4.4
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+-----------------------------

Comment (by swissspidy):

 So, let's have a look at this again for 4.5!

 Some observations:

 * #34278 is something we should strive for, which means we need to make it
 easy for people to customize the embed template.
 * The whole thumbnail image size handling (square / attachment) should be
 simplified or moved to a function.
 * Since the thumbnail is either before or after the heading, basically the
 whole header could be moved to a function. On the other hand, this could
 ''maybe'' be solved using CSS alone.
 * The embed site title, and therefore basically the whole footer, is there
 twice and should be moved to a function

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34561#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list