[wp-trac] [WordPress Trac] #35032: Shiny plugin updates fails if slug has special characters

[WordPress Trac]

#35032: Shiny plugin updates fails if slug has special characters
-------------------------------------+------------------------------
 Reporter:  khag7                    |       Owner:  adamsilverstein
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Upgrade/Install          |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+------------------------------

Comment (by SergeyBiryukov):

 > It will look odd to have sanitize_key used for escaping HTML attributes,
 so a comment is recommended to explain why it is being used.

 I'd suggest keeping the `esc_attr()` for clarity: `esc_attr( sanitize_key(
 $plugin['slug'] ) )`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35032#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform