[wp-trac] [WordPress Trac] #35032: Shiny plugin updates fails if slug has special characters

[WordPress Trac]

#35032: Shiny plugin updates fails if slug has special characters
-------------------------------------+------------------------------
 Reporter:  khag7                    |       Owner:  adamsilverstein
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Upgrade/Install          |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+------------------------------
Changes (by adamsilverstein):

 * owner:   => adamsilverstein
 * status:  new => assigned


Comment:

 @khag7 - Thanks for your bug report. Your detailed explanation pinpoints
 the underlying issue of relying on the plugin slug as the identifying
 mechanism for the plugin being updated, especially considering the
 inconsistent escaping being applied, as you point out.

 While your patch approach looks reasonable, I wanted to point out that
 we've already resolved this issue as work on shiny updates continues: a
 group of us are working on a feature plugin we hope to merge into core in
 the 4.5 release cycle. The goals for a merge include those mentioned in
 this ticket: #31531. Development on this plugin is happening in github,
 and we welcome contributions! https://github.com/obenland/shiny-updates.

 Can you please give the current plugin a try to see if it resolves the
 issue you are having? it would be good to verify the new approach fixes
 the underlying issue.

 In the new version of the plugin, we are allowing bulk updates and
 discovered that users can have multiple plugins with the *same slug* which
 also breaks the ajax return/selection mechanism. For this reason we have
 switched to using the plugin field (not the name, the file path, usually
 plugin/plugin.php). It would be worth exploring whether this could break
 in similar situations for example where emoji or special characters  are
 used in a plugin file name. is that even possible?

 Thanks!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35032#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform