[wp-trac] [WordPress Trac] #34774: Accessibility problem: On update screen, missing aria-label tag from plugin and theme checkboxes
WordPress Trac
noreply at wordpress.org
Fri Dec 11 16:11:34 UTC 2015
#34774: Accessibility problem: On update screen, missing aria-label tag from plugin
and theme checkboxes
-----------------------------+--------------------------------
Reporter: oaron | Owner: afercia
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.5
Component: Upgrade/Install | Version: 2.9
Severity: normal | Resolution:
Keywords: has-patch | Focuses: ui, accessibility
-----------------------------+--------------------------------
Comment (by afercia):
Replying to [comment:3 obenland]:
> I'd probably use `esc_attr( $plugin_file )` and `esc_attr( $stylesheet
)`
Thanks @obenland, wondering if we should use `md5()` as in the plugins
list table and the network themes list table (for consistency):
{{{
`$checkbox_id = "checkbox_" . md5($plugin_data['Name']);`
`$checkbox_id = 'checkbox_' . md5( $theme->get('Name') );`
}}}
`$plugin_file` will give something like `rtl-tester/rtl-tester.php` and
though they're valid, I'm not so happy to use slashes or dots in an
attribute value. But maybe that's just because I'm old :)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/34774#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list