[wp-trac] [WordPress Trac] #34985: Remove PHP4 constructors in wp-includes/pomo/streams.php?
WordPress Trac
noreply at wordpress.org
Thu Dec 10 17:02:35 UTC 2015
#34985: Remove PHP4 constructors in wp-includes/pomo/streams.php?
--------------------------+-----------------------------
Reporter: andg | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: General | Version: 4.4
Severity: normal | Keywords:
Focuses: |
--------------------------+-----------------------------
Hi,
in the `wp-includes/pomo/streams.php` file there's a bunch of PHP4
constructors that could generate a warning when on PHP7, since "methods
with the same name as their class will not be constructors in a future
version of PHP".
Should these be removed, leaving only their PHP5 counterparts?
Also related, the constructor for the `POMO_CachedIntFileReader` class
isn't really needed, since all it does is calling its parent class'
constructor.
Thoughts?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/34985>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list