[wp-trac] [WordPress Trac] #22233: update_option() fails when value has nested objects

[WordPress Trac]

#22233: update_option() fails when value has nested objects
--------------------------------+------------------------------
 Reporter:  exz                 |       Owner:
     Type:  defect (bug)        |      Status:  closed
 Priority:  normal              |   Milestone:  Awaiting Review
Component:  Options, Meta APIs  |     Version:  3.4.2
 Severity:  normal              |  Resolution:  worksforme
 Keywords:                      |     Focuses:
--------------------------------+------------------------------
Changes (by jrf):

 * keywords:  needs-patch needs-testing =>
 * status:  new => closed
 * resolution:   => worksforme


Comment:

 I've been trying to reproduce this issue in order to fix it and have not
 been able to.
 Went back as far as WP 3.7-RC1 to run the unit test and it just keeps
 passing.

 Probably got fixed "accidentally" somewhere along the way between WP 3.5
 and WP 3.7, though I can't see anything in the code to pinpoint what would
 have fixed it.

 @exz do you still have a problem with this ? and if so, could you provide
 a unit test which will fail on trunk ?

 If not, I suggest this ticket should be closed, though it might be a good
 idea to add the unit test to the test suite all the same.

 I'll upload a patch which will add @exz's unit test for this. Props @exz.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/22233#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform