[wp-trac] [WordPress Trac] #34881: Invalid HTML around the input field for searching themes

[WordPress Trac]

#34881: Invalid HTML around the input field for searching themes
----------------------------+--------------------------------------------
 Reporter:  takayukister    |       Owner:  adamsilverstein
     Type:  enhancement     |      Status:  assigned
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Themes          |     Version:  4.3
 Severity:  normal          |  Resolution:
 Keywords:  good-first-bug  |     Focuses:  ui, accessibility, javascript
----------------------------+--------------------------------------------

Comment (by Cheffheid):

 > However, I'd recommend enhancing these inputs to have a form wrapper for
 compatability when, say, JavaScript issues occur or a user has their JS
 disabled. That way, you can explicitly give an address for the input to
 submit to.

 It's probably important to note here that these search input fields are
 pretty much entirely reliant on JavaScript. They will automatically filter
 the list of themes based on what the keyword is, but will also not appear
 at all when JS is disabled. It also doesn't have a submit button, so it's
 not usable as a "traditional form" in its current state.

 Regardless of what we do in regards to adding the `form` element and
 making it work without JS, I'd probably strongly urge to not keep it
 inside of the `h1` on themes.php because of what it does to the heading
 list:

 [[Image(http://i.imgur.com/CeDqUcs.png)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34881#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform