[wp-trac] [WordPress Trac] #34803: Deleting menu item with sub-items does not update sub-items' parent (with disabled JS)
WordPress Trac
noreply at wordpress.org
Mon Dec 7 16:26:14 UTC 2015
#34803: Deleting menu item with sub-items does not update sub-items' parent (with
disabled JS)
----------------------------------------+------------------------------
Reporter: JanVoracek | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Menus | Version: 3.0
Severity: normal | Resolution:
Keywords: has-patch needs-unit-tests | Focuses:
----------------------------------------+------------------------------
Changes (by danielbachhuber):
* keywords: has-patch dev-feedback => has-patch needs-unit-tests
Comment:
Few points of feedback on the patch:
* I like how the logic is internalised to `wp_delete_post()`. Seems
reasonable.
* Like parent post reassignment immediately preceding in the function
call, the procedure should also clear meta cache for affected nav items.
* Needs test coverage.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/34803#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list