[wp-trac] [WordPress Trac] #34886: Search Form should not submit empty strings

WordPress Trac noreply at wordpress.org
Mon Dec 7 05:18:07 UTC 2015


#34886: Search Form should not submit empty strings
-------------------------+------------------------------
 Reporter:  gibrown      |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  General      |     Version:  trunk
 Severity:  normal       |  Resolution:
 Keywords:               |     Focuses:
-------------------------+------------------------------

Comment (by peterwilsoncc):

 +1 on `required`, of recent browser it only misses the Safari family.

 Replying to [comment:2 westonruter]:
 > I think, however, that jQuery should be used for the new functionality,
 and that the JS should be loaded from a JS file instead of inlined to PHP.

 If a JavaScript approach is taken, a feature check for `querySelector` and
 `addEventListener` would be preferable to introducing a jQuery requirement
 for the front end. For similar reasons as in comment:6, loading jQuery and
 jQuery migrate is too heavy handed.

 Uglifying and inlining during the build has worked well to allow unit
 tests of the emoji and embed JS.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34886#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list