[wp-trac] [WordPress Trac] #34891: get_submit_button uses incorrect check for delete class
WordPress Trac
noreply at wordpress.org
Mon Dec 7 01:54:01 UTC 2015
#34891: get_submit_button uses incorrect check for delete class
--------------------------------+-----------------------------
Reporter: rmccue | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Administration | Version:
Severity: normal | Keywords:
Focuses: ui, administration |
--------------------------------+-----------------------------
`get_submit_button` has a special case for the `delete` type:
{{{
if ( 'delete' === $type )
$class = 'button-secondary delete';
}}}
However, `type` can never actually be `'delete'`, as it's always an array:
{{{
if ( ! is_array( $type ) )
$type = explode( ' ', $type );
}}}
I'm not sure this is actually useful to fix though, since `.delete`
doesn't seem to have any styling.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/34891>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list