[wp-trac] [WordPress Trac] #16972: Input type radio losts its checked focus when metabox is dragged

WordPress Trac noreply at wordpress.org
Sun Dec 6 22:22:46 UTC 2015


#16972: Input type radio losts its checked focus when metabox is dragged
-------------------------------------------------+-------------------------
 Reporter:  depi                                 |       Owner:  azaozz
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  4.5
Component:  Administration                       |     Version:  3.0
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch needs-testing 2nd-opinion  |     Focuses:  javascript
  commit                                         |
-------------------------------------------------+-------------------------
Changes (by mdawaffe):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"35809"]:
 {{{
 #!CommitTicketReference repository="" revision="35809"
 Meta Boxes: Preserve radio inputs' state when sorting metaboxes.

 When sorting a metabox, a clone of that metabox is created as a drag/drop
 "helper".
 Previously, any checked radio input in the original metabox would become
 unchecked, when its clone "helper" was inserted into the DOM
 (since only one radio within a set of radios of the same name can be
 checked).

 Continued use of the clone helper is important so that the element being
 dragged isn't subject to the click and other event handlers attached to
 the real metabox,
 so we can't just switch to dragging around the real metabox.  See, for
 example, comment:10:ticket:16972.

 Preserve the radios' state via some name attribute trickery.

 Fixes #16972
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/16972#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list