[wp-trac] [WordPress Trac] #18603: Comments on pages which exceed paginate settings create erroneous permalinks

[WordPress Trac]

#18603: Comments on pages which exceed paginate settings create erroneous
permalinks
-------------------------------------------------+-------------------------
 Reporter:  msagman                              |       Owner:
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
Component:  Comments                             |  Release
 Severity:  normal                               |     Version:  3.2.1
 Keywords:  needs-patch needs-testing good-      |  Resolution:
  first-bug                                      |     Focuses:
-------------------------------------------------+-------------------------

Comment (by ambrosiawt):

 Steps to replicate.  During Contributor Day in Philadelphia today, I spent
 some time on this ticket.  I was able to recreate what I think the
 situation is, although I'm recreating as a situation where nested comments
 were on, and then later turned off.  I think there is still an aspect of
 this that involves a situation where nested comments were off to begin
 with.  I will continue looking at that.  I started looking at a possible
 solution, and I think I have part of the issue identified, but not all of
 it.

 To recreate issue:

         Clean WordPress install
         Set "Enable threaded (nested) comments" to ON
         Created 11 new top-level comments (12 total on Hello World)
         Created 9 2nd level comments on the first top-level comment I
 created
         Created 1 2nd level comment on a different top-level comment I
 created
         Created 1 2nd level comment on the last top-level comment I
 created
         Changed "Break comments into pages with" to 6 entries
         Set "Enable threaded (nested) comment"s to OFF

         Result:
                 The link to the very last 2nd level comment is wrong...
 says page 2.  If you click on it, you don't actually see the comment on
 the page.
                 If you click on the post, the comment shows on the page
 just fine.
                 The link on the comment itself is correct
 (page-2/comments-23), but the link in Recent Comments says page 3 (which
 is incorrect at this point.
                 Since Nested is off, seems like there should really be 4
 total pages of comments, not 2, in this case.

 I attached a dump
 ([https://core.trac.wordpress.org/attachment/ticket/18603/wp_comments_trac_18603.sql])
 of the comments table which you can, on a fresh install, drop the existing
 table and then import this one and then change "Break comments into pages
 with..." to 6, and turn nested comments off.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/18603#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform