[wp-trac] [WordPress Trac] #26963: wp_get_object_terms using wrong orderby statement

WordPress Trac noreply at wordpress.org
Sun Dec 6 16:06:46 UTC 2015


#26963: wp_get_object_terms using wrong orderby statement
-------------------------------+----------------------
 Reporter:  danielvonmitschke  |       Owner:
     Type:  enhancement        |      Status:  closed
 Priority:  normal             |   Milestone:
Component:  Taxonomy           |     Version:  3.8
 Severity:  normal             |  Resolution:  invalid
 Keywords:                     |     Focuses:
-------------------------------+----------------------
Changes (by boonebgorges):

 * keywords:  needs-patch needs-unit-tests =>
 * status:  new => closed
 * resolution:   => invalid
 * milestone:  Future Release =>


Comment:

 Sounds like the issue, as originally reported, is not valid. The
 `wp_terms` table does not have a `term_order` column.

 I don't see the pressing need for a filter on the `orderby` parameter in
 `wp_get_object_terms()`. Such filters create an inconsistent developer
 interface, unless we add them everywhere; but if we add them everywhere,
 we introduce forward-compatibility issues. You can pass `orderby` in the
 function arguments, which seems like plenty to me.

 @dipesh.kakadiya The column is there for historical reasons, and can't be
 moved. If there is a use case for such a column on `wp_term_taxonomy`,
 please open a ticket with the argument. Thanks!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26963#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list