[wp-trac] [WordPress Trac] #33741: Remove references to my-hacks.php and the hack_file option

[WordPress Trac]

#33741: Remove references to my-hacks.php and the hack_file option
-------------------------+------------------------------
 Reporter:  bobbingwide  |       Owner:  jorbin
     Type:  enhancement  |      Status:  reopened
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Plugins      |     Version:  4.3
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+------------------------------

Comment (by nacin):

 The revert was entirely unrelated to `$unusedoptions`. It was done because
 @jorbin was concerned we'd break a few sites without a good reason. The
 was essentially nixing that we should remove `my-hacks.php`, and thus the
 ticket was properly closed as wontfix based on that decision.

 My comment about `$unusedoptions` was *only* that if we were going to go
 through with [34291], then it was useless to keep around the option in the
 DB, and it should also be removed. "Deleting the option could break
 someone's code" is not my concern here — we've removed 'dead' options many
 times before. This is especially OK to do (in a backwards-compatible
 context) when the "default" value (in this case "0") evaluates to false
 (equivalent of it not being in the DB).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33741#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform