[wp-trac] [WordPress Trac] #34831: WP oEmbed: Validate the "Secret" When Used in `document.querySelectorAll()`

WordPress Trac noreply at wordpress.org
Thu Dec 3 09:04:15 UTC 2015

#34831: WP oEmbed: Validate the "Secret" When Used in `document.querySelectorAll()`
 Reporter:  mdawaffe      |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.4
Component:  Embeds        |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  javascript

Comment (by TobiasBg):

 How about just prepending
 if ( /[^a-zA-Z0-9]/.test( data.secret ) ) {
 if we `return` anyways? Would make for a simpler logic, IMO.

Ticket URL: <https://core.trac.wordpress.org/ticket/34831#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list