[wp-trac] [WordPress Trac] #33811: "Attribute content to" dropdown missing when deleting a user in network admin (multisite)

[WordPress Trac]

#33811: "Attribute content to" dropdown missing when deleting a user in network
admin (multisite)
-----------------------------------+-------------------------
 Reporter:  figureone              |       Owner:  jeremyfelt
     Type:  defect (bug)           |      Status:  closed
 Priority:  normal                 |   Milestone:  4.3.1
Component:  Networks and Sites     |     Version:  4.3
 Severity:  normal                 |  Resolution:  fixed
 Keywords:  has-patch fixed-major  |     Focuses:  multisite
-----------------------------------+-------------------------

Comment (by tanguysauvin):

 Hi,

 This patch creates a bug, the former version was correct:
 {{{#!php
 <?php echo __( 'Attribute all content to:' ) . "</label>\n" .
 $user_dropdown; ?></li>
 }}}

 The new version doesn't make sense since _e is a wrapper for echo and
 enclose only 'Attribute all content to:' and not the end of the statement:
 {{{#!php
 <?php _e( 'Attribute all content to:' ) . "</label>\n" . $user_dropdown;
 ?></li>
 }}}

 A really correct version would be (cause commas are a bit faster):
 {{{#!php
 <?php echo __( 'Attribute all content to:' ), "</label>\n",
 $user_dropdown; ?></li>
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33811#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform