[wp-trac] [WordPress Trac] #33207: Add ReverbNation to the internal whitelist of oembed providers
WordPress Trac
noreply at wordpress.org
Mon Aug 31 17:37:47 UTC 2015
#33207: Add ReverbNation to the internal whitelist of oembed providers
-------------------------------+--------------------------
Reporter: rhubbardreverb | Owner: johnbillion
Type: enhancement | Status: reviewing
Priority: normal | Milestone: 4.4
Component: Embeds | Version:
Severity: normal | Resolution:
Keywords: reporter-feedback | Focuses:
-------------------------------+--------------------------
Comment (by rhubbardreverb):
@johnbillion - OK, we have changed the version back to 1.0. This should
go up with this afternoon deploy by 5pm today (8/31/15).
-Robert
Replying to [comment:8 johnbillion]:
> @rhubbardreverb I'm working a suite of unit tests for our oEmbed
providers (see #32360) and it's highlighted the fact that the response
from the Reverbnation oEmbed endpoint is not valid. Can you ask your team
to take a look at the following please?
>
> * The `version` field in the response has a value of `1.1`. There is no
such thing as version 1.1 of [http://oembed.com/ the oEmbed
specification].
> * The `provider-name`, `provider-url`, `author-name`, `author-url`, and
`thumbnail-url` fields are all incorrectly named, as their names should
contain underscores not dashes. I suspect this is deliberate, and the
reason why the endpoint is claiming to be oEmbed version 1.1, but
inventing a specification benefits nobody.
>
> WordPress core doesn't currently use these fields, but oEmbed plugins
often do, and core may well do in the future.
>
> Let me know when you've taken a look!
--
Ticket URL: <https://core.trac.wordpress.org/ticket/33207#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list