[wp-trac] [WordPress Trac] #33543: Featured image meta box absent due to Notices caused by missing labels

[WordPress Trac]

#33543: Featured image meta box absent due to Notices caused by missing labels
-------------------------------+-----------------------------
 Reporter:  bobbingwide        |       Owner:  SergeyBiryukov
     Type:  defect (bug)       |      Status:  reopened
 Priority:  normal             |   Milestone:  4.4
Component:  Posts, Post Types  |     Version:  4.3
 Severity:  normal             |  Resolution:
 Keywords:  has-patch commit   |     Focuses:
-------------------------------+-----------------------------

Comment (by bobbingwide):

 But the notices lead to the Featured image meta-box no longer being
 displayed.
 The code worked fine in 4.2, and was broken in 4.3.

 As an aside, in my opinion, the setting up of labels is done far too
 early.
 The fewer that are set at start up the better.
 Not that I advocate deleting them once they've been defined.

 Perhaps you should defer running the filter and the merge until needed in
 media.php?

 Should there also be an array_merge after 'media_view_strings'?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33543#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform